[PATCH] D52430: =Issue a warning when IFUNC symbols are used and text relocations are allowed.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Remove "=" from the beginning of the first line of the commit message.

Please make it clear that you are proposing a new command line flag.



================
Comment at: ELF/Driver.cpp:832
   Config->WarnCommon = Args.hasFlag(OPT_warn_common, OPT_no_warn_common, false);
+  Config->WarnIFuncTextRel =
+      Args.hasFlag(OPT_warn_ifunc_textrel, OPT_no_warn_ifunc_textrel, false);
----------------
ruiu wrote:
> A new variable name need to be consistent with other variables around it. In this case, all variable names are named after their corresponding command line flags, and the capitalization rule is to make a letter after "_" uppercase and then remove "_".
IFunc -> Ifunc

by that rule.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430