[PATCH] D52322: Pass code-model through Module IR to LTO which will use is

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 10:01:51 PDT 2018


tejohnson added inline comments.


================
Comment at: lib/LTO/LTOBackend.cpp:143
       TheTriple, Conf.CPU, Features.getString(), Conf.Options, RelocModel,
-      Conf.CodeModel, Conf.CGOptLevel));
+      M.getCodeModel(), Conf.CGOptLevel));
 }
----------------
With this change the CodeModel passed in to the LTO link (if any) is ignored. I think this should be like the code that sets the RelocModel just above here.

(As an aside, please upload your patches with context. You can either do so automatically if you use the 'arc' tool, or I think there is a way to do when you create the diff directly - see https://llvm.org/docs/Phabricator.html)


https://reviews.llvm.org/D52322





More information about the llvm-commits mailing list