[PATCH] D52353: Fix asserts when linking wrong address space declarations

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: dexonsmith, efriedma.
Herald added a subscriber: wdng.

https://reviews.llvm.org/D52353

Files:
  lib/Linker/IRMover.cpp
  test/Linker/Inputs/wrong-addrspace-gv-declaration.ll
  test/Linker/wrong-addrspace-gv-declaration.ll


Index: test/Linker/wrong-addrspace-gv-declaration.ll
===================================================================
--- /dev/null
+++ test/Linker/wrong-addrspace-gv-declaration.ll
@@ -0,0 +1,17 @@
+; RUN: llvm-link %s %p/Inputs/wrong-addrspace-gv-declaration.ll -S | FileCheck %s
+; RUN: llvm-link %p/Inputs/wrong-addrspace-gv-declaration.ll %s -S | FileCheck %s
+
+; The address space is declared incorrectly here, so an addrspacecast
+; is needed to link.
+
+ at is_really_as1_gv = external global i32
+ at is_really_as1_gv_other_type = external global i32
+
+; CHECK-LABEL: @foo(
+; CHECK: %load0 = load volatile i32, i32* addrspacecast (i32 addrspace(1)* @is_really_as1_gv to i32*), align 4
+; CHECK: %load1 = load volatile i32, i32* addrspacecast (i32 addrspace(1)* bitcast (float addrspace(1)* @is_really_as1_gv_other_type to i32 addrspace(1)*) to i32*), align 4
+define void @foo() {
+  %load0 = load volatile i32, i32* @is_really_as1_gv, align 4
+  %load1 = load volatile i32, i32* @is_really_as1_gv_other_type, align 4
+  ret void
+}
Index: test/Linker/Inputs/wrong-addrspace-gv-declaration.ll
===================================================================
--- /dev/null
+++ test/Linker/Inputs/wrong-addrspace-gv-declaration.ll
@@ -0,0 +1,2 @@
+ at is_really_as1_gv = addrspace(1) global i32 0, align 4
+ at is_really_as1_gv_other_type = addrspace(1) global float 4.0, align 4
Index: lib/Linker/IRMover.cpp
===================================================================
--- lib/Linker/IRMover.cpp
+++ lib/Linker/IRMover.cpp
@@ -978,11 +978,14 @@
   // containing a GV from the source module, in which case SGV will be
   // the same as DGV and NewGV, and TypeMap.get() will assert since it
   // assumes it is being invoked on a type in the source module.
-  if (DGV && NewGV != SGV)
-    C = ConstantExpr::getBitCast(NewGV, TypeMap.get(SGV->getType()));
+  if (DGV && NewGV != SGV) {
+    C = ConstantExpr::getPointerBitCastOrAddrSpaceCast(
+      NewGV, TypeMap.get(SGV->getType()));
+  }
 
   if (DGV && NewGV != DGV) {
-    DGV->replaceAllUsesWith(ConstantExpr::getBitCast(NewGV, DGV->getType()));
+    DGV->replaceAllUsesWith(
+      ConstantExpr::getPointerBitCastOrAddrSpaceCast(NewGV, DGV->getType()));
     DGV->eraseFromParent();
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52353.166456.patch
Type: text/x-patch
Size: 2259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180921/5e1f48bc/attachment.bin>