[PATCH] D50560: [LLD] Enable Visual Studio compatible diagnostics.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 19:00:16 PDT 2018


ikudrin added a comment.

With overloaded operators we can write something like

  error("relocation " + toString(Type) +
          " cannot refer to absolute symbol: " + toString(Sym) +
          definedAt(toObjLoc(Sym.File)) +
          referencedBy(S.getSymLoc(Sym, RelOff)));

How would you prefer it to look like?
I don't insist on the current style, but I believe it is important to be discussed prior to rewriting the code because the decision will influence the design directly.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50560





More information about the llvm-commits mailing list