[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 15:31:49 PDT 2018


tlively added a comment.

In https://reviews.llvm.org/D52324#1241130, @lebedev.ri wrote:

> I'm somewhat sure this kind of change needs it's own tests, outside of $backend.


I agree, but I couldn't figure out a way to test the non-NaN case in the style of the other ValueTracking tests. The backend has the advantage of being able to observe the ISel DAG in tests, but the ValueTracking tests cannot do so. I'm not aware of any instruction simplifications that depend on the `isKnownNonNaN`. That's not to say they don't exist, but I haven't been able to find one so far.


Repository:
  rL LLVM

https://reviews.llvm.org/D52324





More information about the llvm-commits mailing list