[PATCH] D52317: Add support for dynamic libraries on Hexagon

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 14:13:21 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/Arch/Hexagon.cpp:44
+  PltEntrySize = 16;
+  PltHeaderSize = 0; // MUSL isn't lazy so there is no reason to make a header.
+
----------------
Is this an ABI specification that it doesn't support lazy PLT resolution?


================
Comment at: test/ELF/Inputs/hexagon-shared.s:1
+
+.global bar
----------------
remove the blank line.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52317





More information about the llvm-commits mailing list