[PATCH] D51854: [Arm builtins] Remove non-necessary IS check

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 08:45:08 PDT 2018


peter.smith added a comment.

In https://reviews.llvm.org/D51854#1240515, @hug-dev wrote:

> Ping! I do not mind updating the patch to use 1 instruction instead of 2, as Peter said, if anyone prefers that.


While I personally don't mind the patch is, I think that if there are no other approvals it is safer to update the patch to use 1 instruction instead of 2. What I suggest is to wait to see if there are any approvals by the end of the week and if not, then update the patch to use 1 instruction and I'll approve.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51854





More information about the llvm-commits mailing list