[PATCH] D48575: [GISel]; Add a helper legalization rule for legalizing addressspacecast if no-op

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

This seems like something that most targets would want done by default. I wonder if we should have a standard set of legalizer actions that targets can use. LGTM anyway.



================
Comment at: lib/CodeGen/GlobalISel/LegalityPredicates.cpp:104
+    const LLT &Ty1 = Query.Types[1];
+    assert(Ty0.isPointer() && Ty1.isPointer());
+    return TLI->isNoopAddrSpaceCast(Ty1.getAddressSpace(),
----------------
This should assert already in getAddressSpace().


Repository:
  rL LLVM

https://reviews.llvm.org/D48575