[PATCH] D38513: [LLD] [COFF] Add support for GNU binutils import libraries

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Wow, this patch is almost one year old.



================
Comment at: COFF/Writer.cpp:563
 
+// Sort concrete section chunks from GNU import libraries.
+static bool fixGnuImportChunks(
----------------
Perhaps this is a good place to explain what is GNU import libraries? We shouldn't assume that code readers know what that is when reading this code.


================
Comment at: COFF/Writer.cpp:820
 
-  if (!Idata.empty())
-    for (Chunk *C : Idata.getChunks())
-      IdataSec->addChunk(C);
+    if (File->ThunkSym) {
+      if (!isa<DefinedImportThunk>(File->ThunkSym))
----------------
Flip the condition and continue early.


https://reviews.llvm.org/D38513