[PATCH] D52242: [sanitizer] Destroy and close a range's vmar if all its memory was unmapped

Mark Seaborn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 12:02:38 PDT 2018


mseaborn added a comment.

Suggestion: you could start the commit message with:
"[sanitizer][fuchsia] Fix VMAR leak

Destroy and close a range's vmar if all its memory was unmapped.
..."

i.e. Start the commit message with the goal (fix the leak) and secondarily say how that is achieved.  This should make it more obvious to the reader what the change does.  Otherwise it's not so obvious that this fixes a leak.

I'm not very familiar with this code (and I'm not sure whether this fixes the leak in all cases) so I'll leave the rest of the review to Roland.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52242





More information about the llvm-commits mailing list