[PATCH] D52105: [WebAssembly] Add V128 value type to binary format

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 11:29:50 PDT 2018


aheejin added inline comments.


================
Comment at: test/MC/WebAssembly/types.ll:1
+; RUN: llc -wasm-enable-unimplemented-simd -mattr=+sign-ext,+simd128 -filetype=obj %s -o - | obj2yaml | FileCheck %s
+
----------------
tlively wrote:
> aheejin wrote:
> > What's the purpose of this test?
> It checks that the ValTypes are emitted to an object file correctly, including the new V128 one.
Nit: Then probably it would make more sense to move this to D52254..?


Repository:
  rL LLVM

https://reviews.llvm.org/D52105





More information about the llvm-commits mailing list