[PATCH] D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/cfi-distributed.ll:34
 ; The second index file, corresponding to @test2, should only contain the
 ; typeid for _ZTS1A.
 ; RUN: llvm-dis %t2.o.thinlto.bc -o - | FileCheck %s --check-prefix=INDEX2
----------------
tejohnson wrote:
> This comment seems wrong - I think it should be "should only contain the typeid for _ZTS1A2" (which is what we're checking) - can you fix that? I think the comment/check will also need an update for your change - it should also contain the typeid for _ZTS1B2, right?
_ZTS1A3, done


Repository:
  rL LLVM

https://reviews.llvm.org/D52201