[PATCH] D52258: Fix for bug 34002

[Maya Madhavan via Phabricator via llvm-commits]

maya.madhavan marked 2 inline comments as done.
maya.madhavan added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:9457
   // not legal to branch into an IT block.
   flushPendingInstructions(getStreamer());
   if (NextSymbolIsThumb) {
----------------
olista01 wrote:
> Can this call be removed now? doBeforeLabelEmit and onLabelParsed are only ever called in pairs before and after emitting the label, so there should never be anything to flush here, and as you've pointed out doing it here is incorrect.
Fixed, thanks!


================
Comment at: test/MC/ARM/implicit-it-generation.s:70
 
 @ Flush on a label
   .section test6
----------------
olista01 wrote:
> I think this test already exposes the bug, we just need to add CHECK lines to make sure the labels are emitted in the correct place. That would be clearer than adding a second test to check the label locations.
Updated - thanks!


https://reviews.llvm.org/D52258