[PATCH] D52231: [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC]

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

Thank you for doing this!



================
Comment at: ELF/Arch/PPC64.cpp:88
+
+  llvm_unreachable(
+      "reserved value of 7 in the 3 most-significant-bits of st_other ");
----------------
Please use `error()` and returns a dummy value (e.g. 0) because this place is reachable.


================
Comment at: ELF/Target.h:174
 
+// In the PowerPC64 Elf V2 abi a function can have 2 entry points.  The first is
+// a global entry point (GEP) which typically is used to intiailzie the TOC
----------------
abi -> ABI


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52231