[PATCH] D50800: [ARM] Use correct jump table sizes

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Sorry about the delay.

I think all of this looks appropriate, but ARMConstantIslands has historically been the source of a lot of obscure issues, so I'd like to break this down into multiple patches if possible, to make it easier to bisect if any issues show up.  I guess there are basically three components:

1. Fixing the jumptable size computation.
2. Adding a loop to runOnMachineFunction so we can use this information to improve the emitted instructions in Thumb2
3. Adding ARMConstantIslands::fixupFarBr so we can use this information to improve the emitted instructions in Thumb1.

I guess if we commit the patches in that order, it leaves (1) without any tests, but that's probably okay with an appropriate explanation in the commit message.  Or you could commit (2) first with a testcase that doesn't require a jump table.


https://reviews.llvm.org/D50800