[PATCH] D52242: [sanitizer] Destroy and close a range's vmar if all its memory was unmapped

Mark Seaborn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 12:10:38 PDT 2018


mseaborn added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_fuchsia.cc:287
+  const zx_handle_t vmar = static_cast<zx_handle_t>(os_handle_);
+  UnmapOrDieVmar(reinterpret_cast<void *>(addr), size, vmar);
+  if (!base_) {
----------------
Note that if you're destroying the VMAR, you don't need to unmap any mappings from it first, because destroying the VMAR will remove those mappings.  So you can avoid a syscall in that case.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52242





More information about the llvm-commits mailing list