[PATCH] D52216: [AArch64] Support adding X[8-15, 18] registers as CSRs.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 10:42:50 PDT 2018


nickdesaulniers added inline comments.


================
Comment at: lib/Target/AArch64/AArch64.td:109
+    def FeatureCallSavedX#i : SubtargetFeature<"call-saved-x"#i,
+         "CustomCallSavedXRegs["#i#"]", "true", "Make X"#i#" callee saved.">;
+
----------------
Since x18 can now be call-saved, any thoughts to how llvm should handle x18 being both call-saved and reserved (above line 102)?  Maybe a test can be added for this case?


Repository:
  rL LLVM

https://reviews.llvm.org/D52216





More information about the llvm-commits mailing list