[PATCH] D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: test/CodeGen/X86/pr38763.ll:1
+; RUN: opt %s -S -simplifycfg | FileCheck %s
+
----------------
probinson wrote:
> CarlosAlbertoEnciso wrote:
> > vsk wrote:
> > > Do you need to pipe in the input ('< %s') here? I assumed that opt would write its output to %s.ll otherwise.
> > The pipe is not required. opt write its output to the standard output.
> > I had look at the test cases that use 'opt' and there are 2 ways to invoke it:
> > 
> > (1) RUN: opt <options> < %s
> > 
> > and
> > 
> > (2) RUN: opt <options> %s
> > 
> > The most common format is (1). Changing to use that format.
> > 
> FTR we prefer `< %s` because that way the input path doesn't appear in the output.  The input path can end up causing incorrect CHECK matches, depending on how the checks are written.
Hi Paul,

Thanks for the explanation about the preference on `< %s`.


https://reviews.llvm.org/D51976