[PATCH] D51953: [GlobalISel] Add a new IR canonicalization pass

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 20:57:51 PDT 2018


aditya_nandakumar added a comment.

In https://reviews.llvm.org/D51953#1237504, @aemerson wrote:

> In https://reviews.llvm.org/D51953#1237061, @aditya_nandakumar wrote:
>
> > Hi Amara - would it be possible to add this as part of AArch64 pass pipeline? Adding this to all targets would result in needless burning of compile time for targets that don't need this.
>
>
> I expect other targets to also want to do this at some point, more often than not. I can introduce a target hook to let targets opt out, rather than opt-in, then we can assume for most target's GISel implementation that the IR's been canonicalized?


That sounds reasonable. Thanks


Repository:
  rL LLVM

https://reviews.llvm.org/D51953





More information about the llvm-commits mailing list