[PATCH] D52207: [OCaml] Add OCaml API for LLVMGetIndices

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 18:38:42 PDT 2018


whitequark added inline comments.


================
Comment at: bindings/ocaml/llvm/llvm_ocaml.c:733
+  CAMLparam0();
+  CAMLlocal1(Val_indices);
+  unsigned n = LLVMGetNumIndices(Instr);
----------------
`Val_indices`, by OCaml conventions, is the name for a function that makes an OCaml value from a C value `indices`, which is a bit confusing. Just `indices` would be nicer.


Repository:
  rL LLVM

https://reviews.llvm.org/D52207





More information about the llvm-commits mailing list