[PATCH] D51089: [LLD] [COFF] Add support for creating range extension thunks for ARM

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

In https://reviews.llvm.org/D51089#1237524, @peter.smith wrote:

> Interesting. I think that the implementation you have here will converge faster as it makes it more likely that pass 1 has all the thunks, at the expense of potentially generating more thunks than is strictly required. However if the goal is simplicity I think that you'll need to do everything in one pass, and accept that there will be corner cases that might not link if the margin isn't sufficient. For ELF and arbitrary linker scripts I thought the chance of failure too high, for COFF the chance of failure may be low enough. I think the most likely edge case in COFF will be the presence of sections with high alignment requirements as inserting thunks could cause a lot of bytes of alignment padding to be added.


My apologies I clicked on the wrong link in the email, I should have been looking at https://reviews.llvm.org/D52156. Please ignore the past comment as it won't make much sense. The comment about writing the test might still make sense.


https://reviews.llvm.org/D51089