[PATCH] D51606: [XRay] Remove the deprecated __xray_log_init API

Volodymyr Sapsai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 16:08:11 PDT 2018


vsapsai added a comment.

Who is responsible for updating the clients? Currently in the test suite MicroBenchmarks/XRay/FDRMode/fdrmode-bench.cc is failing to compile because it is using `__xray::FDRLoggingOptions` <https://github.com/llvm-mirror/test-suite/blob/75acfc14c04d4d95c42b7f6dcd44d3e4ac6b5270/MicroBenchmarks/XRay/FDRMode/fdrmode-bench.cc#L29>.

Can you please fix fdrmode-bench.cc to use correct API? Or if it is going to take a lot of time, revert this change?


Repository:
  rL LLVM

https://reviews.llvm.org/D51606





More information about the llvm-commits mailing list