[PATCH] D52055: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 14:05:11 PDT 2018


sfertile added inline comments.


================
Comment at: test/ELF/ppc64-tls-gd-le-small.s:7
+# RUN: llvm-objdump -d %t | FileCheck --check-prefix=CHECK-DIS %s
+# RUN: llvm-readelf -relocations --wide %t | FileCheck --check-prefix=DYN-RELOCS %s
+
----------------
MaskRay wrote:
> Do not have a strong opinion here.. But do you want to use the short form `-r`?
> 
> `--wide` `-W` is actually an ignored option in `llvm-readelf`.
> 
> https://github.com/llvm-mirror/llvm/tree/master/tools/llvm-readobj/llvm-readobj.cpp#L52
I removed the `--wide`, but left the `--relocations` for now  following the discussion on D52124.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52055





More information about the llvm-commits mailing list