[PATCH] D52145: lld-link: Also demangle undefined dllimported symbols.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 08:16:39 PDT 2018


ruiu added a comment.

LGTM. I'm convinced that it makes sense to demangle only C++ names.



================
Comment at: Common/Strings.cpp:43
+  // regular C function that happens to be called __imp__f would be considered
+  // an import stub.
+  std::string Prefix;
----------------
Maybe this comment is too detailed for a first-time reader of this code? I'd just say that we demangle only C++ names.


https://reviews.llvm.org/D52145





More information about the llvm-commits mailing list