[PATCH] D50297: Align AArch64 and i386 image base to superpage

Mon Sep 17 07:49:31 PDT 2018

ruiu added a comment.

I'm fine with this. For lld, we tried to not cargo-cult default image base values,  and the current default values are chosen based on the rationale described in Target.h. If some other value is better than the current default, we shouldn't too hesitate to change that.

Since this patch changes the default image base for AArch64, I'd wait for Peter Smith's LGTM.

================
Comment at: ELF/Arch/X86.cpp:64
+
+  // Align to the non-PAE large page size (known as a superpage or huge page).
+  // FreeBSD automatically promotes large, superpage-aligned allocations.
----------------
I'd s/non-PAE large/4 MiB/ as I don't remember the number.

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50297