[PATCH] D52155: [sanitizer_common] Fuchsia now supports .preinit_array

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 16 14:36:49 PDT 2018


mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.

lgtm.  Note that most sanitizer runtime ports for Fuchsia will be DSO-only, but I think the `#ifndef PIC` condition will cover that if/when those cases come up.
For always-static runtimes that can't be statically linked into DSOs (i.e. runtime library is not included in `-shared` links) this should now be right for Fuchsia.
IIRC profile is always-static but meant to be statically linked separately into each DSO, but presumably that means it's built with `PIC` defined too.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52155





More information about the llvm-commits mailing list