[PATCH] D52142: [DebugInfo] Fix build when std::vector::iterator is a pointer

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 16 11:22:30 PDT 2018


kristina added a comment.

Hi, I know it's a minor change but it should be easy to add a test case for it (a unit test would be appropriate here), especially considering this isn't currently causing issues in any of the current builds as far as I can tell. Also while I'm not insisting, a more-descriptive explanation of the change be nice as it currently, just a sentence or two, so it's more clear on the mailing lists. Thank you.


Repository:
  rL LLVM

https://reviews.llvm.org/D52142





More information about the llvm-commits mailing list