[PATCH] D52143: Make initializeOutputStream() return false on error and true on success.

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington added a comment.

I'd like to know what the LLVM position is here before accepting a style patch like this. I can think of some VIPs (Very Important Procedures) that use either style, but my impression is that true on error is more common, which is why I wrote this function (and a bunch of other functions in the itanium demangler) like this. If you and @zturner feel strongly about this then I don't really mind either way. If you're interested in this issue then I think the right thing to do would be to get the LLVM community to standardize on one or the other.


https://reviews.llvm.org/D52143