[PATCH] D52145: lld-link: Also demangle undefined dllimported symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: Common/Strings.cpp:41
 Optional<std::string> lld::demangleMSVC(StringRef Name) {
+  // Note: This only works while the check for ? below is present, else a
+  // regular C function that happens to be called __imp__f would be considered
----------------
Is "__imp_" name mangling really only for C++ symbol names? I wonder if it's wrong to demangle __imp_f as "__declspec(dllimport) f".


https://reviews.llvm.org/D52145