[PATCH] D51671: [ELF] Set Out::TlsPhdr earlier for encoding packed reloc tables

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 21:46:15 PDT 2018


rprichard updated this revision to Diff 165636.
rprichard added a comment.

I removed const from Out::TlsPhdr and added comments.

I simplified the TLS segment search loop. It could break out of the loop once it finds the segment, which I suppose could be faster, but it doesn't worth the extra lines of code.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51671

Files:
  ELF/Symbols.cpp
  ELF/Writer.cpp
  test/ELF/pack-dyn-relocs-tls-aarch64.s
  test/ELF/pack-dyn-relocs-tls-x86-64.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51671.165636.patch
Type: text/x-patch
Size: 4265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180915/fea17074/attachment.bin>


More information about the llvm-commits mailing list