[PATCH] D51906: [WebAssembly] SIMD shifts

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Does this work when the first argument is not in a splat pattern as well? If so, maybe add a test case for that?



================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:130
 }
+multiclass SIMDShift<ValueType vec_t, string vec, SDNode node, dag pat,
+                     string name, bits<32> simdop> {
----------------
Maybe `shift_amount` or `shift_amount_pat` instead of `pat` to denote this is not the pattern for the whole instruction but for the shift amount operand? 


Repository:
  rL LLVM

https://reviews.llvm.org/D51906