[PATCH] D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/CodeGen/X86/pr38763.ll:113
+!13 = !DIDerivedType(tag: DW_TAG_volatile_type, baseType: !10)
+!14 = !DILocalVariable(name: "read", scope: !7, file: !1, line: 3, type: !10)
+!15 = !DILocalVariable(name: "read1", scope: !7, file: !1, line: 4, type: !10)
----------------
You can strip out all variables that aren't necessary for the test, it makes it easier to read and maintain in the future.


================
Comment at: test/CodeGen/X86/pr38763.ll:122
+!22 = !{!"Simple C++ TBAA"}
+!23 = !DILocation(line: 3, column: 14, scope: !7)
+!24 = !DILocation(line: 3, column: 7, scope: !7)
----------------
You can further simplify the testcase by just using single (or just fewer) DILocation for everything.


https://reviews.llvm.org/D51976