[PATCH] D52112: Fix debug info for SelectionDAG legalization of DAG nodes with two results.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 12:37:40 PDT 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7793
 /// This version can replace From with any result values.  To must match the
 /// number and types of values returned by From.
 void SelectionDAG::ReplaceAllUsesWith(SDNode *From, const SDValue *To) {
----------------
aprantl wrote:
> vsk wrote:
> > Should we assert the first requirement here, i.e `From->getNumValues() == To->getNumValues()`?
> That's not possible, unfortunately, an SDNode can have multiple results each of which is an SDValue. We could change the function to take SmallVectorImpl instead though.
I'll do that in a follow-up commit.


https://reviews.llvm.org/D52112





More information about the llvm-commits mailing list