[PATCH] D52112: Fix debug info for SelectionDAG legalization of DAG nodes with two results.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 11:50:16 PDT 2018


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM, possibly with an added assert. The test looks great!



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7793
 /// This version can replace From with any result values.  To must match the
 /// number and types of values returned by From.
 void SelectionDAG::ReplaceAllUsesWith(SDNode *From, const SDValue *To) {
----------------
Should we assert the first requirement here, i.e `From->getNumValues() == To->getNumValues()`?


https://reviews.llvm.org/D52112





More information about the llvm-commits mailing list