[PATCH] D51561: [CMake] Add support for unittests that have input files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 07:41:53 PDT 2018


thakis added a comment.

> Unrelatedly, another problem with the current design is that llvm.srcdir.txt must contain an absolute path, which makes it impossible to build on one machine and then copy artifacts and test inputs to another machine and run tests on another machine. DebugInfoPDBTests is the only test in all llvm, lld, clang tests that has this restriction. Requiring some defined fixed pwd for unit tests with inputs would address this issue as well. (As would finding a way to not require reading a file off disk for this test.)

This issue could be fixed by treating the path in llvm.srcdir.txt as relative to the test executable (if it's relative).


Repository:
  rL LLVM

https://reviews.llvm.org/D51561





More information about the llvm-commits mailing list