[llvm] r342202 - [NFC] Remove meaningless code from GVN

Max Kazantsev via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 21:50:38 PDT 2018


Author: mkazantsev
Date: Thu Sep 13 21:50:38 2018
New Revision: 342202

URL: http://llvm.org/viewvc/llvm-project?rev=342202&view=rev
Log:
[NFC] Remove meaningless code from GVN

Modified:
    llvm/trunk/lib/Transforms/Scalar/GVN.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/GVN.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GVN.cpp?rev=342202&r1=342201&r2=342202&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/GVN.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/GVN.cpp Thu Sep 13 21:50:38 2018
@@ -2073,18 +2073,12 @@ bool GVN::processBlock(BasicBlock *BB) {
     if (!AtStart)
       --BI;
 
-    const Instruction *MaybeFirstICF = ICF->getFirstICFI(BB);
     for (auto *I : InstrsToErase) {
       assert(I->getParent() == BB && "Removing instruction from wrong block?");
       LLVM_DEBUG(dbgs() << "GVN removed: " << *I << '\n');
       salvageDebugInfo(*I);
       if (MD) MD->removeInstruction(I);
       LLVM_DEBUG(verifyRemoved(I));
-      if (MaybeFirstICF == I) {
-        // We have erased the first ICF in block. The map needs to be updated.
-        // Do not keep dangling pointer on the erased instruction.
-        MaybeFirstICF = nullptr;
-      }
       I->eraseFromParent();
     }
 




More information about the llvm-commits mailing list