[PATCH] D51902: [SanitizerCoverage] Create comdat for global arrays.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 14:20:51 PDT 2018


eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:576
+  if (F.hasLocalLinkage()) {
+    std::string ModuleId = getUniqueModuleId(CurModule);
+    if (ModuleId.empty()) return nullptr;
----------------
Don't call getUniqueModuleId for every function in a module, it's not exactly O(1).



https://reviews.llvm.org/D51902





More information about the llvm-commits mailing list