[PATCH] D51831: [DAGCombine] Fix crash when store merging created an extract_subvector with invalid index

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 13 08:09:32 PDT 2018


niravd accepted this revision.
niravd added a comment.
This revision is now accepted and ready to land.

We should make sure to do the multiplication as (unsigned long long) to give us 64-bits because vectors on the order of 2^16 are potentially reasonable and would cause an overflow at 32-bits.

Otherwise LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D51831





More information about the llvm-commits mailing list