[PATCH] D51933: [AMDGPU] Ensure trig range reduction only used for subtargets that require it

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 20:57:38 PDT 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:6655
+    SDValue MulVal = DAG.getNode(ISD::FMUL, DL, VT, Arg,
+                                 DAG.getConstantFP(0.5 / M_PI, DL, VT));
+    TrigVal = DAG.getNode(AMDGPUISD::FRACT, DL, VT, MulVal);
----------------
Avoid repeating the same constant.

Also we should stop relying on system headers for these constants


Repository:
  rL LLVM

https://reviews.llvm.org/D51933





More information about the llvm-commits mailing list