[PATCH] D51984: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 17:19:57 PDT 2018


beanz added a comment.

I think this should be split into multiple patches. The places you changed `add_library` to `add_llvm_library` should be split out. Also you can break out the unittests/Passes/CmakeLists.txt into its own patch. All of those are good cleanup, and you can commit them without review.

I have the same concern with the bugpoint part of the patch as I do with your clang driver patch. I’m not at my computer, but I can probably take some time tomorrow to look at what it would take to teach `llvm_map_components_to_libnames`, and `llvm_config` to special case Polly.


Repository:
  rL LLVM

https://reviews.llvm.org/D51984





More information about the llvm-commits mailing list