[PATCH] D51753: [DAGCombiner] try to convert pow(x, 1/3) to cbrt(x)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D51753#1232044, @lebedev.ri wrote:

> Looks good, but would be good for someone else to take a look, too.


Thanks! I'll wait a few days at least for more feedback.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp:181-183
   case ISD::FSQRT:                      return "fsqrt";
   case ISD::STRICT_FSQRT:               return "strict_fsqrt";
+  case ISD::FCBRT:                      return "fcbrt";
----------------
lebedev.ri wrote:
> Will `strict_fcbrt` be needed, too?
Not sure. IIUC, we would want that if there's a possibility of converting *from* cbrt to something else. Here, we're only transforming *to* cbrt, so I don't see how a strict sibling would come into play at this point.


https://reviews.llvm.org/D51753