[PATCH] D51968: [deadargelim] Update dbg.value of 'unused' parameters

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with TBAA cruft removed.



================
Comment at: test/Transforms/DeadArgElim/dbginfo-update-dbgval.ll:27
+entry:
+; CHECK: call void @llvm.dbg.value(metadata i32 undef, metadata !15, metadata !DIExpression()), !dbg !16
+  call void @llvm.dbg.value(metadata i32 %k, metadata !15, metadata !DIExpression()), !dbg !16
----------------
vsk wrote:
> aprantl wrote:
> > can you also add a check that f2 no longer has an argument?
> DAE doesn't remove the argument here, see the comment from SurveyFunction:
> ```
> // We consider arguments of non-internal functions to be intrinsically alive as
> // well as arguments to functions which have their "address taken".
> ```
I see. That's fine then.


Repository:
  rL LLVM

https://reviews.llvm.org/D51968