[PATCH] D51995: AMDGPU: Generate VALU ThreeOp Integer instructions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 12:15:29 PDT 2018


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/VOP3Instructions.td:481
+    SDValue Src2 = Operands[2];
+    return (Src0->isDivergent() + Src1->isDivergent() + Src2->isDivergent()) >= 2;
+  }]
----------------
This deserves an explanation I guess.


================
Comment at: lib/Target/AMDGPU/VOP3Instructions.td:524
+class ThreeOp_i32_Pats <SDPatternOperator op1, SDPatternOperator op2, Instruction inst> : GCNPat <
+  (ThreeOpFrag<op1, op2> i32:$src0, i32:$src1, i32:$src2), //(op2 (op1 i32:$src0, i32:$src1), i32:$src2),
+  (inst i32:$src0, i32:$src1, i32:$src2)
----------------
Remove commented code.


Repository:
  rL LLVM

https://reviews.llvm.org/D51995





More information about the llvm-commits mailing list