[PATCH] D51958: [PDB] Emit old fpo data to the PDB

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 09:52:36 PDT 2018


zturner updated this revision to Diff 165106.
zturner added a comment.

I might have gone overboard here, but I wanted to kind of put all `.debug$S` handling into its own function to make the loop simpler and easier to follow.  Since resolving `.debug$S` requires state to be maintained across multiple `.debug$S` sections in a single object file, I made a class out of it and moved a lot of the local state into the class.  `.debug$F` is simpler and doesn't require state across runs so I just handle that directly in the loop.


https://reviews.llvm.org/D51958

Files:
  lld/COFF/PDB.cpp
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
  llvm/include/llvm/Object/COFF.h
  llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
  llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
  llvm/tools/llvm-pdbutil/DumpOutputStyle.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51958.165106.patch
Type: text/x-patch
Size: 21572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180912/55416145/attachment.bin>


More information about the llvm-commits mailing list