[PATCH] D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 09:09:06 PDT 2018


probinson added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:2525
 
+void llvm::dropDebugMetadata(Instruction &I) {
+  SmallVector<DbgVariableIntrinsic *, 1> DbgUsers;
----------------
The function name and the comment in the .h file made me think this is removing the `!dbg` metadata from the specified instruction.  But that's not at all what it does.

People generally don't use the term 'metadata' to refer to the debug intrinsic instructions.  Maybe `dropDebugUsers` would be a better name.



Repository:
  rL LLVM

https://reviews.llvm.org/D51976





More information about the llvm-commits mailing list