[PATCH] D50820: [VPlan] Implement initial vector code generation support for simple outer loops.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlan.cpp:392
+    for (VPBlockBase *SuccVPBlock : VPBB->getHierarchicalSuccessors()) {
+      VPBasicBlock *SuccVPBB = SuccVPBlock->getExitBasicBlock();
+      BBTerminator->setSuccessor(Idx, State->CFG.VPBB2IRBB[SuccVPBB]);
----------------
sguggill wrote:
> rkruppe wrote:
> > Shouldn't this call `getEntryBasicBlock()`? If the successor is a region, the corresponding IR block should jump to the entry block of that region, not to its exit.
> Thank you for pointing this out. This was an oversight. The code was working as all successors were VPBasicBlocks in VPlanNativePath at this point. I have fixed this.
I am not sure if it is possible to construct a test case for that with the restrictions at the moment, but if it is, could you add a test case covering this?


Repository:
  rL LLVM

https://reviews.llvm.org/D50820