[PATCH] D51856: [llvm-exegesis] Improve Register Setup.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 12 01:44:20 PDT 2018


courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Target.cpp:71
+                                     const llvm::APInt &Value) const override {
+    llvm_unreachable("Not yet implemented");
+  }
----------------
this will break exegesis on AARch64. I think we should implement it first.


================
Comment at: unittests/tools/llvm-exegesis/AArch64/TargetTest.cpp:44
 
-TEST_F(AArch64TargetTest, SetRegToConstant) {
-  const std::unique_ptr<llvm::MCSubtargetInfo> STI(
----------------
let's reinstate that.


Repository:
  rL LLVM

https://reviews.llvm.org/D51856





More information about the llvm-commits mailing list