[PATCH] D51858: [llvm-exegesis] Add predefined floating point values so we can test impact of special values on latency.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/RegisterValue.cpp:1
+#include "RegisterValue.h"
+#include "llvm/ADT/APFloat.h"
----------------
missing header


================
Comment at: tools/llvm-exegesis/lib/RegisterValue.cpp:6
+
+static llvm::APFloat GetFloatValue(const llvm::fltSemantics &FltSemantics,
+                                   PredefinedValues Value) {
----------------
getFloatValue


================
Comment at: tools/llvm-exegesis/lib/RegisterValue.h:35
+
+llvm::APInt GetFloatValueAsInteger(const llvm::fltSemantics &FltSemantics,
+                                   PredefinedValues Value);
----------------
style: `getFloatValueAsInteger` 


================
Comment at: tools/llvm-exegesis/lib/RegisterValue.h:35
+
+llvm::APInt GetFloatValueAsInteger(const llvm::fltSemantics &FltSemantics,
+                                   PredefinedValues Value);
----------------
courbet wrote:
> style: `getFloatValueAsInteger` 
I would call this `bitcastFloatValue` or something like this.


Repository:
  rL LLVM

https://reviews.llvm.org/D51858