[PATCH] D51965: reword: cleanup logic in fdr logging

[Dean Michael Berris via Phabricator via llvm-commits]

dberris created this revision.
dberris added reviewers: mboerger, eizan.
Herald added a subscriber: hiraditya.

[XRay] Bug fixes for FDR custom event and arg-logging

This change has a number of fixes for FDR mode in compiler-rt along with
changes to the tooling handling the traces in llvm.

In the runtime, we do the following:

- Advance the "last record" pointer appropriately when writing the custom event data in the log.

- Add XRAY_NEVER_INSTRUMENT in the rewinding routine.

- When collecting the argument of functions appropriately marked, we should not attempt to rewind them (and reset the counts of functions that can be re-wound).

In the tooling, we do the following:

- Remove the state logic in BlockIndexer and instead rely on the presence/absence of records to indicate blocks.

- Move the verifier into a loop associated with each block.


https://reviews.llvm.org/D51965

Files:
  compiler-rt/lib/xray/xray_fdr_logging.cc
  llvm/include/llvm/XRay/BlockIndexer.h
  llvm/lib/XRay/BlockIndexer.cpp
  llvm/lib/XRay/Trace.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51965.165013.patch
Type: text/x-patch
Size: 9762 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180912/ac63c22c/attachment.bin>