[PATCH] D51961: [objcopy] make objcopy follow program header standards

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 11 18:41:33 PDT 2018


mcgrathr added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/Object.cpp:1057
   Ehdr.e_ehsize = sizeof(Elf_Ehdr);
   Ehdr.e_shentsize = sizeof(Elf_Shdr);
   if (WriteSectionHeaders) {
----------------
While you're at it,  don't set shentsize when there are no sections.


https://reviews.llvm.org/D51961





More information about the llvm-commits mailing list